cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Fri, 06 May 2016 07:33:24 GMT
Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/816#issuecomment-217370720
  
    Hi @mike-tutkowski,
    
    I trust you either addressed all my previous remarks, or have a good reason not to.
    I've skimmed (very quickly through the diff) and the code looks good, with small bits,
didn't see any commented out code, plus you added integration tests: seems like a good PR!
    
    So 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message