cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Vmdk findbugs
Date Fri, 06 May 2016 02:27:12 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1530#discussion_r62282456
  
    --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
    @@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) throws IOException {
                 while ((line = in.readLine()) != null) {
                     // ignore empty and comment lines
                     line = line.trim();
    -                if (line.isEmpty())
    +                if (line.isEmpty()) {
                         continue;
    -                if (line.charAt(0) == '#')
    +                }
    +                if (line.charAt(0) == '#') {
    --- End diff --
    
    Why not collapse this check with the one line 52 (e.g. ```if (line.isEmpty() || line.charAt(0)
{```).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message