cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dmabry <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...
Date Fri, 06 May 2016 01:06:07 GMT
Github user dmabry commented on the pull request:

    https://github.com/apache/cloudstack/pull/1529#issuecomment-217322431
  
    I know it doesn't really need my LGTM, but this commit definitely improves the accuracy,
and possibly the performance, of marvin and I'd personally like to see this one merged.  I
have run a few Marvin tests that use this code and it does work as designed.
    
    @swill CI Test good, 2+ reviews. This is Ready to Merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message