cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Wed, 04 May 2016 20:14:25 GMT
Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/816#issuecomment-216987677
  
    Hi @mike-tutkowski
    
    It has indeed been a long time :)
    None the less, it's great that you took the time time write that integration test. I think
it's good to have it even if you are maybe the only one that can run it. I mean, you could
be the "gate keeper" for the stability and reliability of the SolidFire plugin, and report
on the test you run.
    
    I haven't looked in detail at the test, but I'm definitely very happy to see it as part
of this PR. One suggestion that I make (and it's entirely up to you to decide to do it or
not), is to commit the test as part of the PR (I scanned the list of files, while on my phone,
and didn't see it there). A good location for it (one that causes less friction with the BTV
runs) could be 'test/integration/plugins'.
    
    Cheers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message