cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...
Date Tue, 03 May 2016 23:40:19 GMT
Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1529#discussion_r61974295
  
    --- Diff: tools/marvin/marvin/lib/base.py ---
    @@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services, zoneid=None, podid=None,
hyperviso
                       GetDetailExceptionInfo(e)
                 return FAILED
     
    +    @staticmethod
    +    def _check_resource_state(apiclient, hostid, resourcestate):
    +        hosts = Host.list(apiclient, id=hostid, listall=True)
    +
    +        validationresult = validateList(hosts)
    +
    +        if validationresult[0] == FAIL:
    +            raise Exception("Host list validation failed: %s" % validationresult[2])
    --- End diff --
    
    Same comment as above regarding "What if validationresult" is None.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message