cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Date Tue, 03 May 2016 12:09:18 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1444#issuecomment-216508737
  
    @rhtyd, I understand and I agree with your concerns. The point here is that I am not fragmenting
commits, I just cherry picked a commit that was reverted and then I fixed the issues it introduced.
    
    About the commit message, both commits are pretty clear what they do, not?
    
    The commit “7ad3c5e” from @maneesha-p, has the Jira ticket and a description. 
    
    And the commit “6c3d8ca” that I introduced, has only a title, but it is pretty clear
what it is doing (it fix issues that were introduced by a PR). Do you mean that it should
have some Jira ticket opened?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message