cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Date Tue, 03 May 2016 07:23:09 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1502#discussion_r61845772
  
    --- Diff: plugins/outofbandmanagement-drivers/ipmitool/src/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
---
    @@ -0,0 +1,159 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package org.apache.cloudstack.outofbandmanagement.driver.ipmitool;
    +
    +import com.cloud.utils.component.AdapterBase;
    +import com.cloud.utils.exception.CloudRuntimeException;
    +import com.google.common.base.Strings;
    +import com.google.common.collect.ImmutableMap;
    +import org.apache.cloudstack.framework.config.ConfigKey;
    +import org.apache.cloudstack.framework.config.Configurable;
    +import org.apache.cloudstack.outofbandmanagement.OutOfBandManagement;
    +import org.apache.cloudstack.outofbandmanagement.OutOfBandManagementDriver;
    +import org.apache.cloudstack.outofbandmanagement.driver.OutOfBandManagementDriverChangePasswordCommand;
    +import org.apache.cloudstack.outofbandmanagement.driver.OutOfBandManagementDriverCommand;
    +import org.apache.cloudstack.outofbandmanagement.driver.OutOfBandManagementDriverPowerCommand;
    +import org.apache.cloudstack.outofbandmanagement.driver.OutOfBandManagementDriverResponse;
    +import org.apache.log4j.Logger;
    +
    +import javax.ejb.Local;
    +import java.util.Arrays;
    +import java.util.List;
    +
    +@Local(value = {OutOfBandManagementDriver.class})
    +public class IpmitoolOutOfBandManagementDriver extends AdapterBase implements OutOfBandManagementDriver,
Configurable {
    +    public static final Logger LOG = Logger.getLogger(IpmitoolOutOfBandManagementDriver.class);
    +
    +    private static volatile boolean isDriverEnabled = false;
    +    private static boolean isIpmiToolBinAvailable = false;
    --- End diff --
    
    ipmitool path can be changed without restarting mgmt server, the global setting is dynamic
in nature. The path is read from db for each cmd. In case ipmitool path needs tobe updated
or tool need to be installed, this saves admins from restarting mgmt server. Both are static
as Spring creates only one instance of this class and injects them to the core oobm service;
we use them to check whether the driver is enabled and ipmitool binary is available.
    
    On each execute, the initDriver is called to initialize the driver is ipmitool driver
is not successfully initialized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message