cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Date Tue, 03 May 2016 05:10:22 GMT
Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack/pull/1444#issuecomment-216436317
  
    @rafaelweingartner for a project with thousands of commits, splitting the commits for
a PR or bug that solves for the same logical issue results in fragmented history. Both commits
can individually improve the commit messages, at least they can be amended to including the
JIRA bug ID, detail description (what it is, what it solves etc.). Those things are important
and useful when we look back in future. If commits are split into multiple ones, it creates
issue to track them, to port them etc. I suggest you squash them into one commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message