cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...
Date Mon, 02 May 2016 18:28:08 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1385#issuecomment-216319655
  
    Hi @swill no problem, you might be calling me on other PRs, and I might have not answered
you. Sadly, duty is calling these days, few papers were accepted and now I have to work with
all of those bureaucracy and also I have to get a camera ready version; that I why I haven't
had much time to be around here lately. If it is something important you can send me an email.
    
    I have just re-checked this one.
    Although I find the addition of “final” everywhere something that was not needed;
@DaanHoogland knows that I am very picky sometimes ;). What was promised by the PR description
was implemented here, and I am ok with that. 
    
    LGTM here too.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message