cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Security group ingress/egress issues with...
Date Mon, 02 May 2016 10:23:14 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/843#discussion_r61723868
  
    --- Diff: scripts/vm/hypervisor/xenserver/vmops ---
    @@ -356,18 +356,25 @@ def allow_egress_traffic(session):
                     return 'false'
         return 'true'
     
    +def getIpsetType():
    +    try:
    +        util.pread2(['/bin/bash', '-c', "ipset -v | grep 'protocol version: 6'"])
    +        return 'nethash'
    --- End diff --
    
    what is the protocol version is 6, how about we test if it's less than 6 we fallback on
iptreemap otherwise use the netmask type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message