Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6AED819EF4 for ; Wed, 27 Apr 2016 10:56:37 +0000 (UTC) Received: (qmail 39987 invoked by uid 500); 27 Apr 2016 10:56:37 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 39932 invoked by uid 500); 27 Apr 2016 10:56:37 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 39921 invoked by uid 99); 27 Apr 2016 10:56:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Apr 2016 10:56:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9E93FDFDE3; Wed, 27 Apr 2016 10:56:36 +0000 (UTC) From: DaanHoogland To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly Content-Type: text/plain Message-Id: <20160427105636.9E93FDFDE3@git1-us-west.apache.org> Date: Wed, 27 Apr 2016 10:56:36 +0000 (UTC) Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-215048942 LGTM, i had run the tests as well, with no more then the usual problems &*%(^%. Note that part of the change is mine when you take my lgtm for it;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---