Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C037A1958E for ; Tue, 26 Apr 2016 19:11:22 +0000 (UTC) Received: (qmail 25090 invoked by uid 500); 26 Apr 2016 19:11:22 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 25036 invoked by uid 500); 26 Apr 2016 19:11:22 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 25025 invoked by uid 99); 26 Apr 2016 19:11:22 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 19:11:22 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A54C9DFF41; Tue, 26 Apr 2016 19:11:21 +0000 (UTC) From: wido To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur... Content-Type: text/plain Message-Id: <20160426191121.A54C9DFF41@git1-us-west.apache.org> Date: Tue, 26 Apr 2016 19:11:21 +0000 (UTC) Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-214853978 Thanks! I'm not familiar with the VMWare code in CloudStack, so I won't give a LGTM. But passing a version as a Int seems a lot better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---