Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: koushik-das <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1489-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1489-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based
 API C...
Content-Type: text/plain
Message-Id: <20160425111634.B5203DFE16@git1-us-west.apache.org>
Date: Mon, 25 Apr 2016 11:16:34 +0000 (UTC)

Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/1489#issuecomment-214269005
  
    @rhtyd Have you ran the tests using a regular user? As per dynamic checker code, for root admin all checks are bypassed. I think a good comparison will be to run the tests on master with and without dynamic role checker using a regular user so that the DB code path gets exercised.
    
    So are you saying static role checker will no longer be used and the migration of data from commands.properties to DB is forced. Rather than completely removing commands.properties, it will be good to keep both - static checker will only use commands.properties and dynamic checker only goes to DB. The choice should be left with users when they want to migrate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---