Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: pavanb018 <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1304-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1304-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify
 restarti...
Content-Type: text/plain
Message-Id: <20160421122236.927C1DFF8A@git1-us-west.apache.org>
Date: Thu, 21 Apr 2016 12:22:36 +0000 (UTC)

Github user pavanb018 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1304#discussion_r60570371
  
    --- Diff: test/integration/component/test_vpc_network.py ---
    @@ -2748,3 +2751,86 @@ def test_stop_start_vpc_router(self):
             if (exceptionOccured or (not isRouterInDesiredState)):
                 self.fail(exceptionMessage)
             return
    +
    +    @attr(tags=["advanced", "intervlan"], required_hardware="true")
    +    def test_restart_network_with_cleanup(self):
    +        """ Test restart network with cleanup
    +
    +        #1.Acquire pubilc ip
    +        #2.Configure PF rule on acquired ip
    +        #3.Restart network wich leanup
    +        #4.Verify that IP won't be deleted from vpc VR
    +        """
    +        self.public_ip_1 = PublicIPAddress.create(
    +            self.apiclient,
    +            accountid=self.account.name,
    +            zoneid=self.zone.id,
    +            domainid=self.account.domainid,
    +            networkid=self.network_1.id,
    +            vpcid=self.vpc.id
    +        )
    +        NATRule.create(
    +            self.apiclient,
    +            self.vm_1,
    +            self.services["natrule"],
    +            ipaddressid=self.public_ip_1.ipaddress.id,
    +            networkid=self.network_1.id
    +        )
    --- End diff --
    
    @sanju1010  Can we add a validation to make sure that secondary IP is indeed present on the VR even before restarting the network , so that the test will not miss out on the issue where secondary IP was not present on the VR interface even before restart for some reason ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---