Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: koushik-das <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1489-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1489-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based
 API C...
Content-Type: text/plain
Message-Id: <20160420101830.8B9ADDFF48@git1-us-west.apache.org>
Date: Wed, 20 Apr 2016 10:18:30 +0000 (UTC)

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1489#discussion_r60383218
  
    --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java ---
    @@ -0,0 +1,166 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package org.apache.cloudstack.acl;
    +
    +import com.cloud.exception.PermissionDeniedException;
    +import com.cloud.user.Account;
    +import com.cloud.user.AccountService;
    +import com.cloud.user.User;
    +import com.cloud.utils.component.AdapterBase;
    +import com.cloud.utils.component.PluggableService;
    +import com.google.common.base.Strings;
    +import org.apache.cloudstack.api.APICommand;
    +
    +import javax.ejb.Local;
    +import javax.inject.Inject;
    +import javax.naming.ConfigurationException;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +@Local(value = APIChecker.class)
    +public class DynamicRoleBasedAPIAccessChecker extends AdapterBase implements APIChecker {
    +
    +    @Inject
    +    private AccountService accountService;
    +    @Inject
    +    private RoleService roleService;
    +
    +    private List<PluggableService> services;
    +    private Map<RoleType, Set<String>> annotationRoleBasedApisMap = new HashMap<>();
    +
    +    protected DynamicRoleBasedAPIAccessChecker() {
    +        super();
    +        for (RoleType roleType : RoleType.values()) {
    +            annotationRoleBasedApisMap.put(roleType, new HashSet<String>());
    +        }
    +    }
    +
    +    private void denyApiAccess(final String commandName) throws PermissionDeniedException {
    +        throw new PermissionDeniedException("The API does not exist or is blacklisted for the account's role. " +
    +                "The account with is not allowed to request the api: " + commandName);
    +    }
    +
    +    private boolean checkPermission(final List <? extends RolePermission> permissions, final RolePermission.Permission permissionToCheck, final String commandName) {
    +        if (permissions == null) {
    +            return false;
    +        }
    +        for (final RolePermission permission : permissions) {
    +            if (permission.getPermission() != permissionToCheck) {
    --- End diff --
    
    This method would be called for all API calls in case dynamic access checker is enabled. So as long as looping is not a bottleneck its ok. If the use-case require only a few permissions per role then you may leave it for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---