Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 340D619AFB for ; Tue, 19 Apr 2016 19:15:45 +0000 (UTC) Received: (qmail 57178 invoked by uid 500); 19 Apr 2016 19:15:44 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 57123 invoked by uid 500); 19 Apr 2016 19:15:44 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 57107 invoked by uid 99); 19 Apr 2016 19:15:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 19:15:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 69C11DFC70; Tue, 19 Apr 2016 19:15:44 +0000 (UTC) From: swill To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: systemvm: preserve file permissions, set ... Content-Type: text/plain Message-Id: <20160419191544.69C11DFC70@git1-us-west.apache.org> Date: Tue, 19 Apr 2016 19:15:44 +0000 (UTC) Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1420#issuecomment-212074504 @bhaisaab thank you, I appreciate the effort. 👍 I am actively trying to get more people involved in code review, so we will have to lead by example for what we think is reasonable things to ask of developers. Since we do not have solid developer conventions that we all agree on, it does introduce the potential for lots of different opinions to come into play. While I do like the idea of the code moving more towards consistent styling and formatting, this is something we will just have to work through together. As the RM, I will try to remove as much of that friction as I can. Thanks for all your hard work and support. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---