Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: alexandrelimassantana <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1496-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1496-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix
 CheckOnHost ...
Content-Type: text/plain
Message-Id: <20160418040316.AA0E4DFB8E@git1-us-west.apache.org>
Date: Mon, 18 Apr 2016 04:03:16 +0000 (UTC)

Github user alexandrelimassantana commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1496#discussion_r60004052
  
    --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
    @@ -264,6 +265,11 @@ public void scheduleRestartForVmsOnHost(final HostVO host, boolean investigate)
                     "Host [" + hostDesc + "] is down." + ((sb != null) ? sb.toString() : ""));
     
             for (VMInstanceVO vm : reorderedVMList) {
    +            ServiceOfferingVO vmOffering = _serviceOfferingDao.findById(vm.getServiceOfferingId());
    --- End diff --
    
    I would recommend putting this changed inside the if scope in line 273. The additions are related to debug and if the debug is disabled, you can skip it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---