Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D079219F22 for ; Fri, 15 Apr 2016 21:32:52 +0000 (UTC) Received: (qmail 34872 invoked by uid 500); 15 Apr 2016 21:32:52 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 34814 invoked by uid 500); 15 Apr 2016 21:32:52 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 34802 invoked by uid 99); 15 Apr 2016 21:32:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 21:32:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0AE22DFC74; Fri, 15 Apr 2016 21:32:52 +0000 (UTC) From: rafaelweingartner To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res... Content-Type: text/plain Message-Id: <20160415213252.0AE22DFC74@git1-us-west.apache.org> Date: Fri, 15 Apr 2016 21:32:52 +0000 (UTC) Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-210655468 @nvazquez you can create a common super class for those class, and put it into the “cloud-server” project. Additionally, you can remove the “extends ManagerBase”, I can bet it is not needed; so, let’s try removing some unused hierarchy? Also, can you remove the "@Local" annotation? it is not needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---