Return-Path: 
 <dev-return-92056-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2D88C19809
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Fri, 15 Apr 2016 11:50:25 +0000 (UTC)
Received: (qmail 45364 invoked by uid 500); 15 Apr 2016 11:50:19 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 45308 invoked by uid 500); 15 Apr 2016 11:50:19 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 45297 invoked by uid 99); 15 Apr 2016 11:50:19 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 11:50:19 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 6DF05DFBED; Fri, 15 Apr 2016 11:50:19 +0000 (UTC)
From: rafaelweingartner <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1492-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1492-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming
 Policie...
Content-Type: text/plain
Message-Id: <20160415115019.6DF05DFBED@git1-us-west.apache.org>
Date: Fri, 15 Apr 2016 11:50:19 +0000 (UTC)

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1492#discussion_r59863002
  
    --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java ---
    @@ -0,0 +1,32 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package com.cloud.naming;
    +
    +import com.cloud.utils.component.Manager;
    +
    +public interface ResourceNamingPolicyManager extends Manager {
    +
    +
    +    /**
    +     * Finds a resource naming policy among the registered ones by its class
    +     * @param policyClass
    +     * @return
    +     */
    +    @SuppressWarnings("rawtypes")
    +    public <T extends ResourceNamingPolicy> T getPolicy(Class<T> policyClass);
    --- End diff --
    
    I was doing going over your PR and noticed that you have already created those policies as a Spring singletons. It would be a matter of design a way to enable the overwrite through XML configuration. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---