Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: bhaisaab <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1489-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1489-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based
 API C...
Content-Type: text/plain
Message-Id: <20160415103003.B0900DFC13@git1-us-west.apache.org>
Date: Fri, 15 Apr 2016 10:30:03 +0000 (UTC)

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1489#discussion_r59855818
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java ---
    @@ -0,0 +1,104 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +
    +package org.apache.cloudstack.api.command.admin.acl;
    +
    +import com.cloud.user.Account;
    +import com.google.common.base.Strings;
    +import org.apache.cloudstack.acl.Role;
    +import org.apache.cloudstack.acl.RoleType;
    +import org.apache.cloudstack.api.APICommand;
    +import org.apache.cloudstack.api.ApiConstants;
    +import org.apache.cloudstack.api.ApiErrorCode;
    +import org.apache.cloudstack.api.BaseCmd;
    +import org.apache.cloudstack.api.Parameter;
    +import org.apache.cloudstack.api.ServerApiException;
    +import org.apache.cloudstack.api.response.RoleResponse;
    +import org.apache.cloudstack.context.CallContext;
    +
    +@APICommand(name = CreateRoleCmd.APINAME, description = "Creates a role", responseObject = RoleResponse.class,
    +        requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
    +        since = "4.9.0",
    +        authorized = {RoleType.Admin})
    +public class CreateRoleCmd extends BaseCmd {
    +    public static final String APINAME = "createRole";
    +
    +    /////////////////////////////////////////////////////
    +    //////////////// API parameters /////////////////////
    +    /////////////////////////////////////////////////////
    +
    +    @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required = true, description = "creates a role with this unique name")
    +    private String roleName;
    +
    +    @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, required = true, description = "The type of the role, valid options are: Admin, ResourceAdmin, DomainAdmin, User")
    +    private String roleType;
    +
    +    @Parameter(name = ApiConstants.DESCRIPTION, type = CommandType.STRING, description = "The description of the role")
    +    private String roleDescription;
    +
    +    /////////////////////////////////////////////////////
    +    /////////////////// Accessors ///////////////////////
    +    /////////////////////////////////////////////////////
    +
    +    public String getRoleName() {
    +        return roleName;
    +    }
    +
    +    public RoleType getRoleType() {
    +        return RoleType.fromString(roleType);
    +    }
    +
    +    public String getRoleDescription() {
    +        return roleDescription;
    +    }
    +
    +    /////////////////////////////////////////////////////
    +    /////////////// API Implementation///////////////////
    +    /////////////////////////////////////////////////////
    +
    +    @Override
    +    public String getCommandName() {
    +        return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
    +    }
    +
    +    @Override
    +    public long getEntityOwnerId() {
    +        return Account.ACCOUNT_ID_SYSTEM;
    +    }
    +
    +    @Override
    +    public void execute() {
    +        if (Strings.isNullOrEmpty(getRoleName())) {
    +            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Empty role name provided");
    +        }
    +        if (getRoleType() == null || getRoleType() == RoleType.Unknown) {
    +            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Invalid role type provided");
    +        }
    --- End diff --
    
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---