Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: rafaelweingartner <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1403-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1403-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Taking fast and efficient volume
 snapshot...
Content-Type: text/plain
Message-Id: <20160408192924.A8EFFDFC6F@git1-us-west.apache.org>
Date: Fri,  8 Apr 2016 19:29:24 +0000 (UTC)

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r59077175
  
    --- Diff: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java ---
    @@ -23,18 +23,21 @@
     
     import com.cloud.host.Host;
     import com.cloud.storage.StoragePool;
    -import com.cloud.storage.Volume;
     
     public interface PrimaryDataStoreDriver extends DataStoreDriver {
    -    public ChapInfo getChapInfo(VolumeInfo volumeInfo);
    +    public ChapInfo getChapInfo(DataObject dataObject);
     
         public boolean grantAccess(DataObject dataObject, Host host, DataStore dataStore);
     
         public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore);
     
         // intended for managed storage (cloud.storage_pool.managed = true)
         // if not managed, return volume.getSize()
    -    public long getVolumeSizeIncludingHypervisorSnapshotReserve(Volume volume, StoragePool storagePool);
    +    public long getDataObjectSizeIncludingHypervisorSnapshotReserve(DataObject dataObject, StoragePool storagePool);
    +
    +    // intended for zone-wide primary storage that is capable of storing a template once and using it in multiple clusters
    +    // if not this kind of storage, return 0
    +    public long getBytesRequiredForTemplate(TemplateInfo templateInfo, StoragePool storagePool);
    --- End diff --
    
    This is not a proper documentation. 
    I would suggest changing from Java comments style to Javadoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---