Return-Path: 
 <dev-return-91492-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 60D12196D7
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Fri,  8 Apr 2016 13:47:43 +0000 (UTC)
Received: (qmail 23529 invoked by uid 500); 8 Apr 2016 13:47:42 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 23470 invoked by uid 500); 8 Apr 2016 13:47:42 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 23459 invoked by uid 99); 8 Apr 2016 13:47:42 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 13:47:42 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 7C5E3DFC13; Fri,  8 Apr 2016 13:47:42 +0000 (UTC)
From: pdube <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1263-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1263-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Removed unused code from
 com.cloud.api.Ap...
Content-Type: text/plain
Message-Id: <20160408134742.7C5E3DFC13@git1-us-west.apache.org>
Date: Fri,  8 Apr 2016 13:47:42 +0000 (UTC)

Github user pdube commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1263#discussion_r59026583
  
    --- Diff: server/src/com/cloud/api/ApiServer.java ---
    @@ -223,10 +226,7 @@
         private static ExecutorService s_executor = new ThreadPoolExecutor(10, 150, 60, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(), new NamedThreadFactory(
                 "ApiServer"));
         @Inject
    -    MessageBus _messageBus;
    -
    -    public ApiServer() {
    -    }
    +    private MessageBus _messageBus;
    --- End diff --
    
    Why leave the underscore here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---