Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1365-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1365-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: [4.7] vmware: improve support for
 disks
Content-Type: text/plain
Message-Id: <20160406211056.9D58DDFC74@git1-us-west.apache.org>
Date: Wed,  6 Apr 2016 21:10:56 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1365#discussion_r58782564
  
    --- Diff: utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java ---
    @@ -39,4 +38,11 @@ public void setDiskDeviceBusName(String diskDeviceBusName) {
         public void setDiskChain(String[] diskChain) {
             this.diskChain = diskChain;
         }
    +
    +    public String getControllerFromDeviceBusName() {
    +        if (StringUtils.isEmpty(diskDeviceBusName) || !diskDeviceBusName.contains(":")) {
    +            return null;
    --- End diff --
    
    Return an empty string rather than null to avoid potential NPEs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---