Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: GabrielBrascher <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1365-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1365-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: [4.7] vmware: improve support for
 disks
Content-Type: text/plain
Message-Id: <20160406210559.89147DFC74@git1-us-west.apache.org>
Date: Wed,  6 Apr 2016 21:05:59 +0000 (UTC)

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1365#discussion_r58781801
  
    --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
    @@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
                                     throw new InvalidParameterValueException("Cannot migrate ROOT volume of a stopped VM to a storage pool in a different VMware datacenter");
                                 }
                             }
    +
    --- End diff --
    
    @bhaisaab I have to agree with @rafaelweingartner. Create methods is also a great way to improve the code (no just a way to get a reusable code). It helps on keep it readable, ensure its correct implementation by implementing tests, and allows to create Javadoc. I think that it could improve this code too.
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---