From dev-return-91439-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org Thu Apr 7 20:35:11 2016 Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AAFA419353 for ; Thu, 7 Apr 2016 20:35:11 +0000 (UTC) Received: (qmail 56029 invoked by uid 500); 7 Apr 2016 20:35:11 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 55970 invoked by uid 500); 7 Apr 2016 20:35:11 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 55958 invoked by uid 99); 7 Apr 2016 20:35:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Apr 2016 20:35:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5F21A18027E for ; Thu, 7 Apr 2016 20:35:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 8grPzgnPVdeX for ; Thu, 7 Apr 2016 20:35:08 +0000 (UTC) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id AA1D55FB46 for ; Thu, 7 Apr 2016 20:35:07 +0000 (UTC) Received: by mail-wm0-f54.google.com with SMTP id l6so40530335wml.1 for ; Thu, 07 Apr 2016 13:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=RFcPYXy0FcXqFQxBKlSGEoh7KnGvoJUTJ73Bv3OiIOA=; b=h9O6EOp2dvfQ8PiVK8USy5T/6v8gWCv2z9H9qpK6090eKDqbNaTYcEjikopzC+KFUT I32rNy5Pkn7K6D9ekuPlxD6LPTJrRcvxDaCx8n49PXS0tcokTQih8ZKcgVGh4wbTbVOT G7cS4crG8/JVmkD7HJFWcBwVJpDjZaXn+KTegNuNaWc4EhQObDxzBkZ4J3RfW+QmZ3wc LvqJD0Kz73UxSVa2zbo7E4swMtvDU6ewIMifg0qzP2ftbH7L+KAUxjWtVLrjvusBwFJg YmAsfUtgKUAvmzkyJrFHay+qYoTDwUY1pA7IsEOEnSw/Tn+RWPQLSHTcbqUeLk6ktNsn 5qIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=RFcPYXy0FcXqFQxBKlSGEoh7KnGvoJUTJ73Bv3OiIOA=; b=U6miDMBYVDHF6IVAZodMHILcT436RI6zUBVcOU8ANQPUUjey4hxTKIcZHS/8eHGvm/ 4cgot0l4D3t1d0zfUiFvfRCSl1+diugL+ATXMyHILdVrf9+Pv9FgsA59PL7JDwlw5zHu t5iw07omMCsvD8VYzpgtVKZbL/Ye+bSyak8YxL4/1aN30CuVz5fIU0lMYpMV7JhNYc8L AEHCL+j5NsZS+7o48GvriJaPdnbXQx6WOu5nP1DqpIKUi17bWYGQSkXLBPWCn5JpXlDx 7PJ9+2TD1B+2NOLKtVegGEWXRtoCXwirIVY1y560tDoSE+P1LhojOL4N36lsLDhel1DM uGOw== X-Gm-Message-State: AD7BkJKvlMrqXyR53N/nQnNU+RCpgryxFcodRsU/skGs0cxJpcv2UvWTlSlxV6SOcFTMaGohy/oJGbp8eRQGjw== X-Received: by 10.28.29.84 with SMTP id d81mr7558811wmd.59.1460061306666; Thu, 07 Apr 2016 13:35:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.125.67 with HTTP; Thu, 7 Apr 2016 13:34:46 -0700 (PDT) In-Reply-To: <794AF5DA-B467-4B4E-B187-C33FE36A07D1@schubergphilis.com> References: <794AF5DA-B467-4B4E-B187-C33FE36A07D1@schubergphilis.com> From: Daan Hoogland Date: Thu, 7 Apr 2016 22:34:46 +0200 Message-ID: Subject: Re: PRs for 4.9 Release To: dev Content-Type: multipart/alternative; boundary=001a114b461c88da64052feb032f --001a114b461c88da64052feb032f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable For those interested: Fred and I have some adjustments for Fedora and as Cloudstack we need to remain at java 1.7 for now while the SBP guys are ahead of us at 1.8. On Thu, Apr 7, 2016 at 10:30 PM, Remi Bergsma wrote: > Great to see more and more people use the bubbles! > > Setting up: > https://github.com/MissionCriticalCloud/bubble-blueprint > > Using: > https://github.com/MissionCriticalCloud/bubble-toolkit > > Happy testing :-) > > Regards, Remi > > > On 07 Apr 2016, at 19:56, Will Stevens wrote: > > > > If you want me to verify things in your env, you can send me a tmate > > and I can have a look. > > > > *Will STEVENS* > > Lead Developer > > > > *CloudOps* *| *Cloud Solutions Experts > > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 > > w cloudops.com *|* tw @CloudOps_ > > > > On Thu, Apr 7, 2016 at 1:54 PM, Daan Hoogland > > wrote: > > > >> yes, makes perfect sense. I skipped 1326 for now, I just tried to buil= d > >> 1436 it fails in the rpm build fase. I am now going to try that ui > thing to > >> build confidence in my test environment. > >> > >> On Thu, Apr 7, 2016 at 7:49 PM, Rafael Weing=C3=A4rtner < > >> rafaelweingartner@gmail.com> wrote: > >> > >>> Sure it makes. > >>> > >>> > >>> On Thu, Apr 7, 2016 at 2:47 PM, Will Stevens > >>> wrote: > >>> > >>>> Yes, if the PR is ONLY a test and does not touch any other code then > we > >>> can > >>>> only run that test. I agree with you. > >>>> > >>>> If any code is changed outside the test, I always run the full suite= . > >>> Make > >>>> sense? > >>>> > >>>> *Will STEVENS* > >>>> Lead Developer > >>>> > >>>> *CloudOps* *| *Cloud Solutions Experts > >>>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 > >>>> w cloudops.com *|* tw @CloudOps_ > >>>> > >>>> On Thu, Apr 7, 2016 at 1:41 PM, Daan Hoogland < > daan.hoogland@gmail.com > >>> > >>>> wrote: > >>>> > >>>>> running a new test in an environment should pass but should not > >> require > >>>> all > >>>>> other test being re-validated. SO what is the point of running all > >>>> others? > >>>>> I am not saying we shouldn't regularly run all tests but in this ca= se > >>> it > >>>>> adds no value AFAICT. > >>>>> > >>>>> > >>>>> On Thu, Apr 7, 2016 at 7:35 PM, Will Stevens > >>>>> wrote: > >>>>> > >>>>>> Yes, I want to run tests against the tests. I have found issues i= n > >>>> some > >>>>> of > >>>>>> the tests not working as expected, so I add the test to the run an= d > >>> run > >>>>>> them. I think it is worth it because then we know the test is > >> valid > >>>>>> later. I would rather have the author fix the test now if there > >> are > >>>>>> problems than having to work through it later. > >>>>>> > >>>>>> I am going to be doing a big push on getting testing cleaned up, s= o > >>>> when > >>>>> I > >>>>>> start going through all the tests and validating them, I want to > >>> reduce > >>>>> the > >>>>>> amount of work I have to do, so validating the tests at source > >> makes > >>>>> sense. > >>>>>> :) > >>>>>> > >>>>>> *Will STEVENS* > >>>>>> Lead Developer > >>>>>> > >>>>>> *CloudOps* *| *Cloud Solutions Experts > >>>>>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 > >>>>>> w cloudops.com *|* tw @CloudOps_ > >>>>>> > >>>>>> On Thu, Apr 7, 2016 at 1:30 PM, Daan Hoogland < > >>> daan.hoogland@gmail.com > >>>>> > >>>>>> wrote: > >>>>>> > >>>>>>> 1326 is just a test. it does not touch production code. Do we run > >>>>>>> regression tests against such PRs. seems a waste to me. > >>>>>>> > >>>>>>> On Thu, Apr 7, 2016 at 7:27 PM, Daan Hoogland < > >>>> daan.hoogland@gmail.com > >>>>>> > >>>>>>> wrote: > >>>>>>> > >>>>>>>> > >>>>>>>> On Thu, Apr 7, 2016 at 7:26 PM, Daan Hoogland < > >>>>> daan.hoogland@gmail.com > >>>>>>> > >>>>>>>> wrote: > >>>>>>>> > >>>>>>>>> 1326 - master (*pending CI) > >>>>>>>> > >>>>>>>> > >>>>>>>> =E2=80=8Bstarting=E2=80=8B > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Daan > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> Daan > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> Daan > >>> > >>> > >>> > >>> -- > >>> Rafael Weing=C3=A4rtner > >> > >> > >> > >> -- > >> Daan > >> > --=20 Daan --001a114b461c88da64052feb032f--