From dev-return-92617-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org Fri Apr 22 14:18:33 2016 Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 046AA198E0 for ; Fri, 22 Apr 2016 14:18:33 +0000 (UTC) Received: (qmail 50770 invoked by uid 500); 22 Apr 2016 14:18:32 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 50715 invoked by uid 500); 22 Apr 2016 14:18:32 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 50704 invoked by uid 99); 22 Apr 2016 14:18:32 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 14:18:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E8DB4DFCE0; Fri, 22 Apr 2016 14:18:31 +0000 (UTC) From: jburwell To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C... Content-Type: text/plain Message-Id: <20160422141831.E8DB4DFCE0@git1-us-west.apache.org> Date: Fri, 22 Apr 2016 14:18:31 +0000 (UTC) Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60745471 --- Diff: utils/src/main/java/com/cloud/utils/PropertiesUtil.java --- @@ -34,6 +34,10 @@ public class PropertiesUtil { private static final Logger s_logger = Logger.getLogger(PropertiesUtil.class); + public static String getDefaultApiCommandsFileName() { + return "commands.properties"; + } --- End diff -- Why is this method not defined in a common class/interface of the authenticator mechanism? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---