cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...
Date Mon, 18 Apr 2016 18:01:31 GMT
GitHub user mike-tutkowski opened a pull request:

    https://github.com/apache/cloudstack/pull/1501

    Fixing an issue in Marvin around creating a template from a snapshot

    This fixes the following ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9354
    
    The problem was that Marvin was requiring you to pass in the "ispublic" parameter when
creating a template from a snapshot.
    
    As the ticket notes, this issue was introduced by the following commit: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d
    
    The solution I've provided is simply to check if the "ispublic" property is in the dictionary
before referencing it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-tutkowski/cloudstack cs-9354

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1501
    
----
commit df85825c1a7870b2de56898fb15ff2bb8323b490
Author: Mike Tutkowski <mike.tutkowski@solidfire.com>
Date:   2016-04-18T17:56:08Z

    CLOUDSTACK-9354 - Fixing an issue in Marvin around creating a template from a snapshot
(if “is public” is not provided, there was a problem)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message