cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Remove unused params from NetworkHelperIm...
Date Sun, 10 Apr 2016 03:45:23 GMT
GitHub user GabrielBrascher opened a pull request:

    https://github.com/apache/cloudstack/pull/1484

    Remove unused params from NetworkHelperImpl.start method

    The contributions of this PR are:
    
    - Removed unused params ("User" and "Account") from:
    	- method that does nothing with the variables:
    com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO,
    Map<Param, Object>, DeploymentPlan);
    	- method that calls the "NetworkHelperImpl.start" method:
    com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
    Map<Param, Object>);
    	- method from the interface :
    com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
    Map<Param, Object>).
    
    - removed **_** from variables names: private variables with **_** at the
    beginning is common in C++ but not in Java;
    - changed access level of some variables from protected or public to private;
    - removed variables that are not read.
    
    This PR intends to perform simple changes in order to improve the code of the following
classes:
    	- com.cloud.network.router.NetworkHelper
    	- com.cloud.network.router.NetworkHelperImpl
    	- com.cloud.network.router.VirtualNetworkApplianceManagerImpl
    	- com.cloud.network.router.VpcVirtualNetworkApplianceManagerImpl
    	- com.cloud.network.router.VpcNetworkHelperImpl

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GabrielBrascher/cloudstack brascher-NetworkHelperImplUnusedParams

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1484
    
----
commit 893bdeea24a64818ff5ede2059393930565d462d
Author: gabrascher <gabrascher@hotmail.com>
Date:   2016-04-10T03:26:02Z

    Remove unused params from NetworkHelperImpl.start.
    
    This commit also changes the access level of variables, removes
    unused variables and "_" from beginning of names.
    
    - Remove unused params ("User" and "Account") from:
    	- method that does nothing with the variables:
    com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO,
    Map<Param, Object>, DeploymentPlan);
    	- method that calls the start method:
    com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
    Map<Param, Object>);
    	- method from the interface :
    com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
    Map<Param, Object>).
    
    - Removed “_” from variables names: private variables with “_” at the
    beginning is common in C++ but not in Java;
    - Methods and variables access level reviewed, changing some variables
    from protected or public to private;
    - Remove variables that are not read.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message