cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix concurrency issue on virtual router
Date Thu, 07 Apr 2016 17:37:10 GMT
GitHub user remibergsma opened a pull request:

    https://github.com/apache/cloudstack/pull/1465

    Fix concurrency issue on virtual router

    The json files now have UUIDs to prevent them from getting overwritten before they've
been executed. Prevents config to be pushed to the wrong router :-s
    
    ```
    2016-02-25 18:32:23,797 DEBUG [c.c.a.t.Request] (AgentManager-Handler-1:null) (logid:)
Seq 2-4684025087442026584: Processing:  { Ans: , MgmtId: 90520732674657, via: 2, Ver: v1,
Flags: 10, [{"com.cloud.agent.api.routing.GroupA
    nswer":{"results":["null - success: null","null - success: [INFO] update_config.py ::
Processing incoming file => vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b\n[INFO]
Processing JSON file vm_dhcp_entry.json.4ea4506
    1-2efb-4467-8eaa-db3d77fb0a7b\n"],"result":true,"wait":0}}] }
    ```
    
    On the router:
    ```
    2016-02-25 18:32:23,416  merge.py __moveFile:298 Processed file written to /var/cache/cloud/processed/vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b.gz
    ```
    
    ![screen shot 2016-02-25 at 19 33 17](https://cloud.githubusercontent.com/assets/1630096/13329886/acdae4fc-dbf6-11e5-8c20-fdc6661f5a0b.png)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/remibergsma/cloudstack 47_fix_concurrency_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1465
    
----
commit f632215b0493b210201fa7590db00ce64cf25e4a
Author: Miguel Ferreira <miguelferreira@me.com>
Date:   2016-02-25T13:32:09Z

    Make the generated json files unique to prevent concurrency issues
    
    Backported from Cosmic.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message