cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...
Date Fri, 29 Apr 2016 21:44:58 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1496#discussion_r61649158
  
    --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
    @@ -264,6 +265,11 @@ public void scheduleRestartForVmsOnHost(final HostVO host, boolean
investigate)
                     "Host [" + hostDesc + "] is down." + ((sb != null) ? sb.toString() :
""));
     
             for (VMInstanceVO vm : reorderedVMList) {
    +            ServiceOfferingVO vmOffering = _serviceOfferingDao.findById(vm.getServiceOfferingId());
    --- End diff --
    
    @alexandrelimassantana I don't see where ``vmOffering`` is being used only for debug.
 It is being used on line 269 to determine if the VM is using local storage -- before debugging
logging code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message