cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Date Thu, 28 Apr 2016 08:34:50 GMT
Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack/pull/1489#issuecomment-215352448
  
    @DaanHoogland @wido @mlsorensen @jburwell @agneya2001 @koushik-das @terbolous @resmo @K0zka
 review and LGTM please?
     
    @swill I think we've resolved all outstanding concerns, and if there are still any concern
that should be shared, summary;
    - Existing users are not migrated automatically, they continue to use static-checker,
@koushik-das raised concern if dynamic-checker is forced upon users -- it is not
    - Commands.properties file is only removed from codebase, after an upgrade this file won't
be removed by the deb/rpm packages, @koushik-das raised concern on not removing it -- it is
clarified that it's not for users with existing deployments
    - Valid points raised by @mlsorensen on why dynamic checker is the way forward and static-checker
has several pain points for real world users
    - @koushik-das raised concerns about code quality and testing, my colleague @borisstoyanov
 and I have spent good time to test the feature against ldap, saml and native cloudstack authentication;
along with upgrade and regression tests around the feature. The integration test runs with
Travis as well, providing nearly 100% coverage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message