cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...
Date Wed, 27 Apr 2016 15:14:51 GMT
Github user nvazquez commented on the pull request:

    https://github.com/apache/cloudstack/pull/1518#issuecomment-215116050
  
    Thanks @rafaelweingartner, I like the idea, I think the best way would be leave hierarchy
like this:
    
    ````
    - Command
        -- NEW CLASS
            --- StorageCommand
            --- SsCommand
            --- CopyVolumeCommand
            --- SecStorageSetupCommand
            --- GetStorageStatsCommand
    
    - TemplateOrVolumePostUploadCommand
    ````
    
    This way it can be avoided `nfsVersion` parameter in every class in Command hierarchy,
because they won't need it, and just leave `TemplateOrVolumePostUploadCommand` separate in
this hierarchy. Would this be ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message