cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...
Date Wed, 27 Apr 2016 13:33:27 GMT
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1348#issuecomment-215084100
  
    So if I am following this correctly, we are all set.  @rhtyd requested a change to move
the test data to an overridable location, but did not require this change for his LGTM.  @DaanHoogland
would have to restructure the plugin in order to make that happen and feels it is outside
the scope of this fix and would prefer to address that to a future improvement.  Does that
all make sense?
    
    I will put this in my merge queue, but will wait for confirmation that we are good to
go before merging.  Thanks guys...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message