cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Date Sat, 23 Apr 2016 09:24:47 GMT
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1502#issuecomment-213702911
  
    I added a few comments, but before I continue:
    - Why assume a IP-Address and not a hostname OR IP? I know enough IPMIs why are available
through a DNS hostname
    - Why is so much passed as a String through the code instead of a native type like integer
or inetaddress
    
    My first look looks good, but I can't test this easily.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message