cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Date Sat, 23 Apr 2016 09:22:09 GMT
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1502#discussion_r60825823
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
    @@ -0,0 +1,127 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package org.apache.cloudstack.api.command.admin.outofbandmanagement;
    +
    +import com.cloud.exception.ConcurrentOperationException;
    +import com.cloud.exception.InsufficientCapacityException;
    +import com.cloud.exception.NetworkRuleConflictException;
    +import com.cloud.exception.ResourceAllocationException;
    +import com.cloud.exception.ResourceUnavailableException;
    +import com.cloud.host.Host;
    +import com.google.common.base.Strings;
    +import com.google.common.collect.ImmutableMap;
    +import org.apache.cloudstack.acl.RoleType;
    +import org.apache.cloudstack.api.APICommand;
    +import org.apache.cloudstack.api.ApiConstants;
    +import org.apache.cloudstack.api.ApiErrorCode;
    +import org.apache.cloudstack.api.BaseCmd;
    +import org.apache.cloudstack.api.Parameter;
    +import org.apache.cloudstack.api.ServerApiException;
    +import org.apache.cloudstack.api.response.HostResponse;
    +import org.apache.cloudstack.api.response.OutOfBandManagementResponse;
    +import org.apache.cloudstack.context.CallContext;
    +import org.apache.cloudstack.outofbandmanagement.OutOfBandManagement;
    +import org.apache.cloudstack.outofbandmanagement.OutOfBandManagementService;
    +
    +import javax.inject.Inject;
    +
    +@APICommand(name = "configureOutOfBandManagement", description = "Configures a host's
out-of-band management interface",
    +        responseObject = OutOfBandManagementResponse.class, requestHasSensitiveInfo =
true, responseHasSensitiveInfo = false, authorized = {RoleType.Admin})
    +public class ConfigureOutOfBandManagementCmd extends BaseCmd {
    +    @Inject
    +    private OutOfBandManagementService outOfBandManagementService;
    +
    +    /////////////////////////////////////////////////////
    +    //////////////// API parameters /////////////////////
    +    /////////////////////////////////////////////////////
    +
    +    @Parameter(name = ApiConstants.HOST_ID, type = CommandType.UUID, entityType = HostResponse.class,
required = true, description = "the ID of the host")
    +    private Long hostId;
    +
    +    @Parameter(name = ApiConstants.DRIVER, type = CommandType.STRING, required = true,
description = "the host management interface driver, for example: ipmitool")
    +    private String driver;
    +
    +    @Parameter(name = ApiConstants.IP_ADDRESS, type = CommandType.STRING, required =
true, description = "the host management interface IP address")
    +    private String address;
    +
    +    @Parameter(name = ApiConstants.PORT, type = CommandType.STRING, required = true,
description = "the host management interface port")
    --- End diff --
    
    Why is the port numer a String and not a Integer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message