cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Date Fri, 22 Apr 2016 17:18:07 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1489#discussion_r60772677
  
    --- Diff: utils/src/main/java/com/cloud/utils/PropertiesUtil.java ---
    @@ -34,6 +34,10 @@
     public class PropertiesUtil {
         private static final Logger s_logger = Logger.getLogger(PropertiesUtil.class);
     
    +    public static String getDefaultApiCommandsFileName() {
    +        return "commands.properties";
    +    }
    --- End diff --
    
    PropertiesUtil deals with commands.properties file related processing, so I've put it
here. Also, utils is a common packages used by several other modules, putting this in an authenticator
(server or plugin package) won't make it generally consumable across several modules if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message