cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Date Fri, 22 Apr 2016 13:22:06 GMT
Github user jburwell commented on a diff in the pull request:
    --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/
    @@ -119,6 +131,9 @@ private Long getDomainId() {
         public void execute() throws ServerApiException {
    +        if (getAccountType() == null && getRoleId() == null) {
    +            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Both account type
and role ID are not provided");
    --- End diff --
    Why not mark these two parameters as required and let the framework perform the validation?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message