cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Date Fri, 22 Apr 2016 11:58:05 GMT
Github user bhaisaab commented on a diff in the pull request:
    --- Diff: api/src/org/apache/cloudstack/api/response/ ---
    @@ -233,6 +234,9 @@ public void addTag(ResourceTagResponse tag) {
         public void setResourceDetails(Map<String, String> details) {
    -        this.resourceDetails = details;
    +        if (details == null) {
    --- End diff --
    yes, if its null no point in setting it as nothing will be marshaled by gson/xml processor,
also we don't want to consume the map but create a new copy out of it to avoid polluting user's

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message