cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dmabry <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...
Date Thu, 21 Apr 2016 14:02:08 GMT
Github user dmabry commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1500#discussion_r60585058
  
    --- Diff: test/integration/component/test_volumes.py ---
    @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
                     "Check the state of VM"
                 )
             except Exception as e:
    -            self.fail("Exception occuered: %s" % e)
    +            self.fail("Exception occurred: %s" % e)
    +        return
    +    
    +    @attr(tags=["advanced", "advancedns"], required_hardware="false")
    +    def test_02_root_volume_attach_detach(self):
    +        """Test Root Volume attach/detach to VM
    +        """
    +
    +        # Validate the following
    +        # 1. Deploy a VM
    +        # 2. Verify that we are testing a supported hypervisor
    +        # 3. Check for root volume
    +        # 4. Stop VM
    +        # 5. Detach root volume
    +        # 6. Verify root volume detached
    +        # 7. Attach root volume
    +        # 8. Start VM
    +        
    +        # Verify we are using a supported hypervisor
    +        if (self.hypervisor.lower() == 'vmware'
    +                or self.hypervisor.lower() == 'kvm'
    +                or self.hypervisor.lower() == 'simulator'
    +                or self.hypervisor.lower() == 'xenserver'):
    +        
    +            try:
    +                # Check for root volume
    +                root_volume_response = Volume.list(
    +                    self.apiclient,
    +                    virtualmachineid=self.virtual_machine.id,
    +                    type='ROOT',
    +                    listall=True
    +                )
    +                self.assertNotEqual(
    +                    root_volume_response,
    +                    None,
    +                    "Check if root volume exists in ListVolumes"
    +                )
    +                self.assertEqual(
    +                    isinstance(root_volume_response, list),
    +                    True,
    +                    "Check list volumes response for valid list"
    +                )
    +                # Grab the root volume for later use
    +                root_volume = root_volume_response[0]
    +                
    +                # Stop VM
    +                self.debug("Stopping the VM: %s" % self.virtual_machine.id)
    +                self.virtual_machine.stop(self.apiclient)
    +                
    +                # Ensure VM is stopped before detaching the root volume
    +                time.sleep(self.services["sleep"])
    +    
    +                vm_response = VirtualMachine.list(
    +                    self.apiclient,
    +                    id=self.virtual_machine.id,
    +                )
    +                vm = vm_response[0]
    +                self.assertEqual(
    +                    vm.state,
    +                    'Stopped',
    +                    "Check the state of VM"
    +                )
    +                
    +                # Detach root volume from VM
    +                self.virtual_machine.detach_volume(
    +                    self.apiclient,
    +                    root_volume
    +                )
    +                
    +                # Verify that root disk is gone
    +                no_root_volume_response = Volume.list(
    +                    self.apiclient,
    +                    virtualmachineid=self.virtual_machine.id,
    +                    type='ROOT',
    +                    listall=True
    +                )
    +                self.assertEqual(
    +                    no_root_volume_response,
    +                    None,
    +                    "Check if root volume exists in ListVolumes"
    +                )
    +                
    +                # Attach root volume to VM
    +                self.virtual_machine.attach_volume(
    +                    self.apiclient,
    +                    root_volume,
    +                    0
    +                )
    +                
    +                # Check for root volume
    +                new_root_volume_response = Volume.list(
    +                    self.apiclient,
    +                    virtualmachineid=self.virtual_machine.id,
    +                    type='ROOT',
    +                    listall=True
    +                )
    +                self.assertNotEqual(
    +                    new_root_volume_response,
    +                    None,
    +                    "Check if root volume exists in ListVolumes"
    +                )
    +                self.assertEqual(
    +                    isinstance(new_root_volume_response, list),
    +                    True,
    +                    "Check list volumes response for valid list"
    +                )
    +                
    +                # Start VM
    +                self.virtual_machine.start(self.apiclient)
    +                # Sleep to ensure that VM is in ready state
    +                time.sleep(self.services["sleep"])
    --- End diff --
    
    @jburwell - Thanks for the feedback.  I will make the suggested changes as it make complete
sense to wait_until instead of waiting for an arbitrary amount of time that may be too long
or not long enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message