cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Date Tue, 19 Apr 2016 16:01:34 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1497#issuecomment-211994713
  
    The method name is ok. I just asked to confirm how you see the method workings. I only
feel that the Javadoc should say that, whenever the ID variable is not null, it is the only
one that is going to be used and returned in the List. Also, we should have a test for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message