cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Date Mon, 18 Apr 2016 17:28:49 GMT
Github user nvazquez commented on the pull request:

    https://github.com/apache/cloudstack/pull/1497#issuecomment-211487161
  
    Thanks @rafaelweingartner I made a refactor based in your comments. I could remove "extends
ManagerBase" from <code>QueryManagerImpl</code> but not from <code>VMSnapshotManagerImpl</code>
and <code>SnapshotManagerImpl</code> so I decided to create static methods and
use the new class as a helper instead of a superclass, do you think this is ok?
    
    I couldn't find <code>@Local</code> to remove it, in which file did you mean
to remove it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message