cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Date Fri, 15 Apr 2016 18:15:05 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1497#discussion_r59917122
  
    --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java ---
    @@ -1731,6 +1731,17 @@
             Long zoneId = cmd.getZoneId();
             Long podId = cmd.getPodId();
     
    +        List<Long> ids = null;
    --- End diff --
    
    Would you mind extracting lines 1734-1744 to a method? Then, you could write test cases
and even create some documentation for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message