cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <>
Subject [GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...
Date Fri, 15 Apr 2016 11:12:40 GMT
Github user rafaelweingartner commented on a diff in the pull request:
    --- Diff: api/src/com/cloud/naming/ ---
    @@ -0,0 +1,32 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +public interface ResourceNamingPolicyManager extends Manager {
    +    /**
    +     * Finds a resource naming policy among the registered ones by its class
    +     * @param policyClass
    +     * @return
    +     */
    +    @SuppressWarnings("rawtypes")
    +    public <T extends ResourceNamingPolicy> T getPolicy(Class<T> policyClass);
    --- End diff --
    Let’s check if I understood this method.
    It will look up for a naming policy that is registered given a naming policy class, right?
    The registered policy is an instance of that class that is sent as a parameter, right?
If I already know the class I need, why look for an instance of it?
    What about creating singletons those classes using spring? And then, just injecting them
where needed. Sorry if overlooked something, but have you tried to design some solution that
uses IoC instead of creating our own?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message