cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Date Fri, 15 Apr 2016 10:26:25 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1489#discussion_r59855472
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java
---
    @@ -196,5 +204,8 @@ private void validateParams() {
             if(StringUtils.isEmpty(getPassword())) {
                 throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Empty passwords are
not allowed");
             }
    +        if (getAccountType() == null && getRoleId() == null) {
    --- End diff --
    
    Fixed the roleId < 1L issue.
    No, here the check is for maintaining backward compatibility. The accounttype used to
be a 'required' param, but now it's optional, and so is 'roleid'; this check is to ensure
that at least one of the two are provided


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message