cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Date Thu, 14 Apr 2016 18:01:11 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1331#issuecomment-210078579
  
    @jburwell I agree with you that all static can be final. I disagree that loggers should
be static, but that is a matter of taste. I understand the cache methods of Log4J, but still
I do not like much of using static variables. It feels more natural to use the instance attribute
when logging.
    
    I find it much more complications to add an appender and then use it to test if some method
has been used or some message logged.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message