cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Date Thu, 14 Apr 2016 04:49:05 GMT
Github user syed commented on the pull request:

    https://github.com/apache/cloudstack/pull/1331#issuecomment-209759974
  
    For sure @rafaelweingartner. As I have outlined in my mail to you, I've been basically
following the practices that have been put in place by the previous developers. If they are
not the most optimal/best ways to do things, I am willing to learn the right way. 
    
    I've seen your PR. You've made the logger a `protected` variable instead of a `static
final` Can you tell me the difference? Is one preferred over the other? In all the code that
I've seen on cloudstack, the `s_logger` is `public static final`. Do you have knowldege of
why it was done so? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message