cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Date Wed, 13 Apr 2016 08:59:49 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1489#discussion_r59514818
  
    --- Diff: engine/schema/src/com/cloud/user/AccountVO.java ---
    @@ -83,8 +86,16 @@ public AccountVO(String accountName, long domainId, String networkDomain,
short
             this.domainId = domainId;
             this.networkDomain = networkDomain;
             this.type = type;
    -        state = State.enabled;
    +        this.state = State.enabled;
             this.uuid = uuid;
    +        this.roleId = RoleType.getRoleByAccountType(null, type);
    +    }
    +
    +    public AccountVO(String accountName, long domainId, String networkDomain, short type,
Long roleId, String uuid) {
    +        this(accountName, domainId, networkDomain, type, uuid);
    --- End diff --
    
    all these params can be final right? (probably missed that one in all the code above)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message