cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Remove unused images
Date Tue, 12 Apr 2016 12:54:23 GMT
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1475#issuecomment-208891268
  
    Isn't there references to these files?  Forget the ones in `target`, but the references
in `cloudstack/scripts/installer/windows/client.wxs` should probably be addressed...
    
    Thoughts?
    
    ```
    Searching 15246 files for "sample-project-view.png"
    
    cloudstack/client/target/cloud-client-ui-4.9.0-SNAPSHOT.war:
        File too large, skipping
    
    cloudstack/client/target/cloud-client-ui-4.9.0-SNAPSHOT/WEB-INF/classes/scripts/installer/windows/client.wxs:
      170                      </Component>
      171                      <Component Id="cmp6E186870ED4CF468177D7449592B651D" Guid="{1735AF1A-2962-4A6C-9103-A1B891920977}">
      172:                         <File Id="filFC755B88B988B6799CCF3B813EFE8E8F" KeyPath="yes"
Source="!(wix.SourceClient)\images\sample-project-view.png" />
      173                      </Component>
      174                      <Component Id="cmp1C89ADB77497A7903954C1555FE7D35D" Guid="{9795E109-A613-4891-A396-F6FCDA1121FA}">
    
    cloudstack/client/target/generated-webapp/WEB-INF/classes/scripts/installer/windows/client.wxs:
      170                      </Component>
      171                      <Component Id="cmp6E186870ED4CF468177D7449592B651D" Guid="{1735AF1A-2962-4A6C-9103-A1B891920977}">
      172:                         <File Id="filFC755B88B988B6799CCF3B813EFE8E8F" KeyPath="yes"
Source="!(wix.SourceClient)\images\sample-project-view.png" />
      173                      </Component>
      174                      <Component Id="cmp1C89ADB77497A7903954C1555FE7D35D" Guid="{9795E109-A613-4891-A396-F6FCDA1121FA}">
    
    cloudstack/scripts/installer/windows/client.wxs:
      170                      </Component>
      171                      <Component Id="cmp6E186870ED4CF468177D7449592B651D" Guid="{1735AF1A-2962-4A6C-9103-A1B891920977}">
      172:                         <File Id="filFC755B88B988B6799CCF3B813EFE8E8F" KeyPath="yes"
Source="!(wix.SourceClient)\images\sample-project-view.png" />
      173                      </Component>
      174                      <Component Id="cmp1C89ADB77497A7903954C1555FE7D35D" Guid="{9795E109-A613-4891-A396-F6FCDA1121FA}">
    
    3 matches across 3 files
    
    
    Searching 15246 files for "vm-instance-screen-sample.png"
    
    cloudstack/client/target/cloud-client-ui-4.9.0-SNAPSHOT.war:
        File too large, skipping
    
    cloudstack/client/target/cloud-client-ui-4.9.0-SNAPSHOT/WEB-INF/classes/scripts/installer/windows/client.wxs:
      176                      </Component>
      177                      <Component Id="cmp033EEE431FC34259BCA1CE1B246E50F4" Guid="{FEF35205-58DB-42E6-9C9A-2C9CE2C46527}">
      178:                         <File Id="filABF125D326B2B2880F897A3B8356A17C" KeyPath="yes"
Source="!(wix.SourceClient)\images\vm-instance-screen-sample.png" />
      179                      </Component>
      180                  </Directory>
    
    cloudstack/client/target/generated-webapp/WEB-INF/classes/scripts/installer/windows/client.wxs:
      176                      </Component>
      177                      <Component Id="cmp033EEE431FC34259BCA1CE1B246E50F4" Guid="{FEF35205-58DB-42E6-9C9A-2C9CE2C46527}">
      178:                         <File Id="filABF125D326B2B2880F897A3B8356A17C" KeyPath="yes"
Source="!(wix.SourceClient)\images\vm-instance-screen-sample.png" />
      179                      </Component>
      180                  </Directory>
    
    cloudstack/scripts/installer/windows/client.wxs:
      176                      </Component>
      177                      <Component Id="cmp033EEE431FC34259BCA1CE1B246E50F4" Guid="{FEF35205-58DB-42E6-9C9A-2C9CE2C46527}">
      178:                         <File Id="filABF125D326B2B2880F897A3B8356A17C" KeyPath="yes"
Source="!(wix.SourceClient)\images\vm-instance-screen-sample.png" />
      179                      </Component>
      180                  </Directory>
    
    3 matches across 3 files
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message