cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...
Date Mon, 11 Apr 2016 19:07:09 GMT
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1363#issuecomment-208504591
  
    So my understand is there was a FindBugs issue originally.  In the process of fixing the
issue, some logic was changed to introduce an issue.  This commit is to revert to the original
code that had the FindBugs issue.  I guess it is a lesser of two evils.  If this goes in,
I think we should do what @DaanHoogland suggested and up the number of findbugs to account
for the known findbug issues in this commit.  This way we are not spammed with findbugs issues
and if other commits have findbugs issues, we are correctly notified.  Does that make sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message