cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Mon, 11 Apr 2016 03:17:07 GMT
Github user jburwell commented on a diff in the pull request:
    --- Diff: api/src/com/cloud/network/vpc/ ---
    @@ -0,0 +1,332 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +import java.util.Arrays;
    +import java.util.HashMap;
    +import java.util.Map;
    +import org.apache.commons.lang.ArrayUtils;
    +import org.apache.commons.lang.StringUtils;
    +public class OSPFZoneConfig {
    +    private long zoneId;
    +    private Protocol protocol;
    +    private String ospfArea;
    +    private Short helloInterval;
    +    private Short deadInterval;
    +    private Short retransmitInterval;
    +    private Short transitDelay;
    --- End diff --
    @abhinandanprateek why did you chose to represent these time values as ``Short`` rather
than ``Duration``?  My issue with ``Short`` is there is no notion of units (e.g. seconds,
milliseconds) etc.  Therefore, the conversion semantics are impossible to determine when just
represented as a numeric value.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message